fix: fix runtime errors with better-auth 1.4.x API changes#8
Open
Hashibutogarasu wants to merge 1 commit intoyultyyev:mainfrom
Open
fix: fix runtime errors with better-auth 1.4.x API changes#8Hashibutogarasu wants to merge 1 commit intoyultyyev:mainfrom
Hashibutogarasu wants to merge 1 commit intoyultyyev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes runtime errors that occur when using the plugin with better-auth 1.4.x.
Changes
Fix
createAuthMiddlewareimport pathcreateAuthMiddlewarewas moved frombetter-auth/pluginstobetter-auth/apiin better-auth 1.4.x. Using the old path causes a runtime module resolution error.Update
internalAdapterAPI calls to match 1.4.x signaturesSeveral
internalAdaptermethod signatures changed in better-auth 1.4.x:updateUser({ id, ...fields })updateUser(id, { ...fields })createSession({ userId, expiresAt })createSession(userId, undefined, { expiresAt })adapter.getAccount()internalAdapter.findOAuthUser()adapter.upsertAccount / createAccountinternalAdapter.linkAccount()/internalAdapter.updateAccount()Use
GenericEndpointContextinstead of hand-crafted typeReplaced the local
Contexttype (which usedany) with the officialGenericEndpointContexttype exported frombetter-auth, improving type safety.Fix optional chaining on
context.pathIn better-auth 1.4.18,
context.pathcan beundefined. Added optional chaining (context.path?.startsWith()) with a fallback to prevent runtime crashes in hook matchers.Testing